Simple refactoring operations that will make the SQL handler easier to maintain/fox

Description

  • Remove most #if 0 ... #endif lines

  • Remove, or replace with BESDEBUG, instances of TESTDEBUG. Use CLion's debugger for virtually all of these

  • Remove most of the #if TEST==1 ... #endif lines

  • Remove the likely unused template construct template< T1, T2, ERROR_TYPE, MSG_TYPE=ERROR_TYPE> with template< T1, T2> if possible. This _MSG_TYPE=ERROR_TYPE_ substring appears in three places (connector/SQLConnector.h, connector/SQLLErrorConnector.h, DEM/SQLErrorFactory.h). I commented it out with no apparent effect. Not sure how to go about removing the template args and use a simple type name. In the code, typedef std::string MSG_TYPE; appears in templates/Types.h and unixODBC/ODBCTypes.h. Same for typedef SQLRETURN ERROR_TYPE;

Just hack on these as time permits

Status

Assignee

James Gallagher

Reporter

James Gallagher

Priority

Medium

Labels

Story Points

2

Fix versions

None

Epic Link

Configure